fix: update check failing with TypeError (#5877)

since 22.11.1 the update check was failing with TypeError: update_notifier_1.default is not a function
electron-userland · May 11, 2021 · 7884b50 · 7884b50
1 parent 3e6c10f
commit 7884b50
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 29 deletions.
diff --git a/package.json b/package.json
@@ -40,6 +40,7 @@
     "dmg-license": "~1.0.8"
   },
   "devDependencies": {
+    "@types/update-notifier": "^5.0.0",
     "@typescript-eslint/eslint-plugin": "^4.23.0",
     "@typescript-eslint/parser": "^4.23.0",
     "eslint": "^7.26.0",

diff --git a/packages/electron-builder/src/cli/cli.ts b/packages/electron-builder/src/cli/cli.ts
@@ -7,7 +7,7 @@ import { pathExists, readJson } from "fs-extra"
 import isCi from "is-ci"
 import * as path from "path"
 import { loadEnv } from "read-config-file"
-import updateNotifier from "update-notifier"
+import * as updateNotifier from "update-notifier"
 import { ExecError } from "builder-util/out/util"
 import { build, configureBuildCommand, createYargs } from "../builder"
 import { createSelfSignedCert } from "./create-self-signed-cert"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/typings/updateNotifier.d.ts b/typings/updateNotifier.d.ts