Skip to content

Commit

Permalink
fix: notarization with an apple API key (#7951)
Browse files Browse the repository at this point in the history
Notarization wasn't actually running when the API key is set and notarize was set to true. The notarize tool library throws when a API key is provided and teamId is set, so you have to set notarize to true, but when you do currently, the step never runs.
  • Loading branch information
bcomnes authored Dec 20, 2023
1 parent 47e66ca commit 869c7e4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/shaggy-plums-live.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: notarization with an apple API key
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/macPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
return proj
}
const { teamId } = options as NotarizeNotaryOptions
if (teamId && (legacyLogin || notaryToolLogin)) {
if ((teamId || options === true) && (legacyLogin || notaryToolLogin)) {
const proj: NotaryToolStartOptions = {
appPath,
...(legacyLogin ?? notaryToolLogin!),
Expand Down

0 comments on commit 869c7e4

Please sign in to comment.