fix: prevent infinite looping of overwriteArtifact during Github publ…

…ishing (#6958)
electron-userland · Jun 23, 2022 · 8ffd9d4 · 8ffd9d4
1 parent 4e90504
commit 8ffd9d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/wild-crabs-prove.md b/.changeset/wild-crabs-prove.md
@@ -0,0 +1,5 @@
+---
+"electron-publish": patch
+---
+
+fix: prevent infinite error looping of overwriteArtifact during github artifact uploads
diff --git a/packages/electron-publish/src/gitHubPublisher.ts b/packages/electron-publish/src/gitHubPublisher.ts
@@ -198,12 +198,10 @@ export class GitHubPublisher extends HttpPublisher {
         requestProcessor
       )
       .catch(e => {
-        if (this.doesErrorMeanAlreadyExists(e)) {
-          return this.overwriteArtifact(fileName, release).then(() => this.doUploadFile(attemptNumber, parsedUrl, fileName, dataLength, requestProcessor, release))
-        }
-
         if (attemptNumber > 3) {
           return Promise.reject(e)
+        } else if (this.doesErrorMeanAlreadyExists(e)) {
+          return this.overwriteArtifact(fileName, release).then(() => this.doUploadFile(attemptNumber + 1, parsedUrl, fileName, dataLength, requestProcessor, release))
         } else {
           return new Promise((resolve, reject) => {
             const newAttemptNumber = attemptNumber + 1