Skip to content

Commit

Permalink
fix: add missing %U in desktop file of appimages (#4909)
Browse files Browse the repository at this point in the history
* fix missing %U in desktop file of appimages

this should fix #4035

* fix test
  • Loading branch information
Simon-Laux authored Sep 22, 2020
1 parent b8c9cd0 commit d96b3d3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/app-builder-lib/src/targets/AppImageTarget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default class AppImageTarget extends Target {
constructor(ignored: string, private readonly packager: LinuxPackager, private readonly helper: LinuxTargetHelper, readonly outDir: string) {
super("appImage")

this.desktopEntry = new Lazy<string>(() => helper.computeDesktopEntry(this.options, "AppRun", {
this.desktopEntry = new Lazy<string>(() => helper.computeDesktopEntry(this.options, "AppRun %U", {
"X-AppImage-Version": `${packager.appInfo.buildVersion}`,
}))
}
Expand Down Expand Up @@ -90,4 +90,4 @@ export default class AppImageTarget extends Target {
updateInfo: await executeAppBuilderAsJson(args),
})
}
}
}
2 changes: 1 addition & 1 deletion test/snapshots/linux/linuxPackagerTest.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`AppImage - default icon, custom executable and custom desktop 1`] = `
"[Desktop Entry]
Name=Test App ßW
Exec=AppRun
Exec=AppRun %U
Terminal=true
Type=Application
Icon=Foo
Expand Down

0 comments on commit d96b3d3

Please sign in to comment.