Skip to content

Commit

Permalink
fix: respect the signDlls flag (#5133)
Browse files Browse the repository at this point in the history
Although the flag was checked against in signing DLLs in the extra
files and resources, the files in the asar unpacked directory were
not using the same check.
  • Loading branch information
fonsleenaars authored Jul 9, 2020
1 parent ff117bc commit db6e762
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/winPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {

const outResourcesDir = path.join(packContext.appOutDir, "resources", "app.asar.unpacked")
// noinspection JSUnusedLocalSymbols
const fileToSign = await walk(outResourcesDir, (file, stat) => stat.isDirectory() || file.endsWith(".exe") || file.endsWith(".dll"))
const fileToSign = await walk(outResourcesDir, (file, stat) => stat.isDirectory() || file.endsWith(".exe") || (this.isSignDlls() && file.endsWith(".dll")))
await BluebirdPromise.map(fileToSign, file => this.sign(file), {concurrency: 4})
}
}

0 comments on commit db6e762

Please sign in to comment.