fix(nsis): Do not abort when uninstaller fails (#5292)

Do not abort installation when the uninstaller is missing, fails to run or returns error code.
electron-userland · Sep 17, 2020 · ea9281b · ea9281b
1 parent fca50ae
commit ea9281b
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/packages/app-builder-lib/templates/nsis/include/installUtil.nsh b/packages/app-builder-lib/templates/nsis/include/installUtil.nsh
@@ -179,18 +179,14 @@ Function uninstallOldVersion
     ifErrors 0 ExecErrorHandler
       # this also failed...
       DetailPrint `Aborting, uninstall was not successful. Not able to launch uninstaller!`
-      SetErrorLevel 5
-      Abort "Cannot uninstall"
   ExecErrorHandler:
   ${if} $R0 != 0
     DetailPrint `Aborting, uninstall was not successful. Uninstaller error code: $R0.`
-    SetErrorLevel 5
-    Abort "Cannot uninstall"
   ${endif}
   Done:
 FunctionEnd
 
 !macro uninstallOldVersion ROOT_KEY
   Push "${ROOT_KEY}"
   Call uninstallOldVersion
-!macroend
+!macroend