Skip to content

Commit

Permalink
fix: dmg-license-dependency (#6248)
Browse files Browse the repository at this point in the history
* fix: Adding dmg-builder as an optional dependency for electron-builder and app-builder-lib so as to not block linux installations
  • Loading branch information
mmaietta authored Sep 10, 2021
1 parent 36e32a4 commit f359035
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .changeset/stale-rocks-wonder.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"app-builder-lib": patch
"dmg-builder": patch
---

fix: dmg-license as an optional dependency while still enabling docs site to build properly
3 changes: 3 additions & 0 deletions netlify-docs.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#!/usr/bin/env bash
pip3 install pipenv
pipenv install
echo "Installing pnpm"
npx pnpm install --store=./node_modules/.pnpm-store
echo "Building site docs"
mkdocs build
3 changes: 3 additions & 0 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
[Build]
Publish = ""
Functions = ""

[build.environment]
NPM_FLAGS = "--version"
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
"repository": "https://github.com/electron-userland/electron-builder",
"///": "All dependencies for all packages (hoisted)",
"////": "All typings are added into root `package.json` to avoid duplication errors in the IDE compiler (several `node.d.ts` files).",
"dependencies": {
"dmg-license": "1.0.9"
},
"devDependencies": {
"@babel/plugin-transform-modules-commonjs": "7.15.0",
"@changesets/changelog-github": "0.4.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/app-builder-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,9 @@
"@types/is-ci": "3.0.0",
"@types/js-yaml": "4.0.3",
"@types/semver": "7.3.8",
"dmg-builder": "workspace:*",
"electron-builder-squirrel-windows": "workspace:*"
},
"//": "electron-builder-squirrel-windows added as dev dep for tests (as otherwise `require` doesn't work using Yarn 2)",
"//": "electron-builder-squirrel-windows and dmg-builder added as dev dep for tests (as otherwise `require` doesn't work using Yarn 2)",
"typings": "./out/index.d.ts"
}
4 changes: 3 additions & 1 deletion packages/dmg-builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@
"app-builder-lib": "workspace:*",
"builder-util": "workspace:*",
"builder-util-runtime": "workspace:*",
"dmg-license": "^1.0.9",
"fs-extra": "^10.0.0",
"iconv-lite": "^0.6.2",
"js-yaml": "^4.1.0"
},
"optionalDependencies": {
"dmg-license": "^1.0.9"
},
"devDependencies": {
"@types/fs-extra": "9.0.12",
"@types/js-yaml": "4.0.3",
Expand Down
8 changes: 7 additions & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f359035

Please sign in to comment.