Set platform npm environment variable

[lgeiger]

• Version: 10.8.1

• Target: all

prebuild now fully supports Electron and works great together with electron-builder and the npmSkipBuildFromSource option.

Additionally it would be great if electron-builder could expose the platform it builds for to a npm environment variable (npm_config_platform) during the rebuilding of native modules.

This way prebuild would be able to download the correct prebuilt binary for the desired target.
This would make multi platform builds with native dependencies possible.

[mmckegg]

@lgeiger I actually added support for this on my own branch but never PR'd it because it was a bit hacky.

https://github.com/mmckegg/electron-builder/commit/e0936afe3701f6507a2856ea7ee4421e5c0a2af9

[develar]

@mmckegg Would you like to send PR?

[develar]

Will be implemented soon.

[lgeiger]

@develar Thanks for the fast response!

I just tried v10.9.0 and it doesn't fully work yet:

$ npm run pack

> nteract@0.0.15 pack /Users/lukasgeiger/code/nteract
> npm install && npm run clean && npm run build && build --dir --linux

> nteract@0.0.15 postinstall /Users/lukasgeiger/code/nteract
> install-app-deps

Rebuilding native production dependencies for darwin:x64

I use build --dir --linux and it still builds for mac (darwin:x64). Or am I missing something.

[lgeiger]

I'm sorry, the log (Rebuilding native production dependencies for darwin:x64 was coming from the npm install command.

I'll investigate further.