Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic unpack detection in scoped packages unpacks the entire scope #1540

Closed
pmoleri opened this issue May 11, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Automatic unpack detection in scoped packages unpacks the entire scope #1540

pmoleri opened this issue May 11, 2017 · 2 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@pmoleri
Copy link

pmoleri commented May 11, 2017

  • Version: 17.5.0
  • Target: Windows

I have multiple packages under the same npm scope, say:

  • @example/foo (with dlls)
  • @example/bar

As result, all packages under @example get unpacked.

app.asar.unpacked/
    node_modules
        @example/
            foo/
            bar/

although bar shouldn't.

Running in debug mode:
export DEBUG="electron-builder"; ./node_modules/.bin/build,
it prints the following message:

electron-builder node_modules\@example is not packed into asar archive - contains executable code
@develar develar added the bug label May 12, 2017
@develar
Copy link
Member

develar commented May 12, 2017

Confirmed.

develar added a commit to develar/electron-builder that referenced this issue May 13, 2017
@pmoleri
Copy link
Author

pmoleri commented May 15, 2017

Thanks! Already tested it in v17.8.0 and it's working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants