Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squirrel.Windows: options.name is invalid #1743

Closed
eanders-ms opened this issue Jun 26, 2017 · 2 comments · Fixed by EHDFE/ehdev-shell#205, Thorium-Sim/thorium-kiosk#40 or Thorium-Sim/thorium-kiosk#41 · May be fixed by qcif/data-curator#563

Comments

@eanders-ms
Copy link

  • Version: 19.8.0
  • Target: squirrelWindows

I am transitioning my app from Squirrel.Windows to NSIS, and in the process updating the name of my application. Existing installations of my app use Squirrel.Windows to auto-update, and so for backward compatibility reasons, I need the build output of the squirrelWindows target to output the previous application name. Perusing the source of electron-builder-squirrel-windows, it appears that the name option is the configuration I need, but it isn't exposed. I get this error when I try to set it:

[09:25:48] Error: Config is invalid:
{
  "squirrelWindows": [
    {
      "name": "Unknown option"
    },
    "Invalid option object"
  ]
}

Yet, it is in SquirrelOptions:
(in electron-builder/packages/electron-builder-squirrel-windows/src/squirrelPack.ts)

export interface SquirrelOptions {
 ...
  name: string
... 
}

Any chance it could be included in the exposed options?

@develar
Copy link
Member

develar commented Jun 26, 2017

Fix will be available today.

@develar
Copy link
Member

develar commented Jun 26, 2017

For obvious reasons this option will be not documented and not tested (well, in any case I cannot right now because my iMac is broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment