Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer authors is not properly read from package.json #196

Closed
demetris-manikas opened this issue Mar 3, 2016 · 0 comments
Closed

Comments

@demetris-manikas
Copy link
Contributor

To create a linux installer I had to change the application package.json "author":"blah" to "author":{
"name":"blah", "email": "blah@blah.com"}. This had a side effect in the windows installer where the authors field (Publisher in the add/remove programs) to read [Object object].

Adding the owners field in the win section of the development package.json fixes the problem.
Having in mind that the project uses electronjs/windows-installer I filed a PR there that fixes the problem (it was just a typo https://github.com/electronjs/windows-installer/pull/16/files).

And then it hit me.

While the docs state that electron-packager and https://github.com/electronjs/windows-installer are used under the hood, the truth is that some temporary-forks are actually being used.
I really don't see any reason (nor have the time to do so) to create PRs on temporary forks.

For the typo mentioned I might have done it but I don't feel like altering the following code found in electron-winstaller-temp-fork/index.js
metadata.authors = (ref4 = (ref5 = (ref6 = metadata.author) != null ? ref6.name : void 0) != null ? ref5 : metadata.author) != null ? ref4 : '';

Maybe somebody else does....

develar added a commit to develar/electron-builder that referenced this issue Mar 3, 2016
Tests refactored to simplify new test addition
ESLint added to check test code

Closes electron-userland#184, electron-userland#196
@develar develar closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants