Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity issues with nsis-web #2049

Closed
mastergberry opened this issue Sep 8, 2017 · 11 comments
Closed

Connectivity issues with nsis-web #2049

mastergberry opened this issue Sep 8, 2017 · 11 comments
Labels

Comments

@mastergberry
Copy link
Contributor

  • Version: 15.4.3
  • Target: Windows (Nsis-Web)

image

I'm not sure if this was fixed in later versions, but i've had a few miscellaneous reports here and there that people are having issues download sometimes from cloudfront (AWS S3 CDN). I've seen other screenshots (I don't have atm) that show a user having issues with the download stopping like 1/3 of the way through saying it lost connection and can't continue and consistently doing this when he had no other internet issues.

Are there any known bugs with the nsis-web downloader plugins being used?

@develar develar added the nsis label Sep 8, 2017
@develar
Copy link
Member

develar commented Sep 8, 2017

I am not aware.

We should:

  1. try 3 times before user confirmation to retry.
  2. try to download without proxy.

@develar
Copy link
Member

develar commented Sep 8, 2017

BTW, user now (next version will be released), can

Download package file into the same directory where installer located. It will be detected automatically and used instead of downloading from the Internet. Please note — only original package file is allowed (checksum is checked).

@mastergberry
Copy link
Contributor Author

Is it possible for the download to resume if it does lose connectivity? Or not possible with the way it downloads the files.

@mastergberry
Copy link
Contributor Author

mastergberry commented Sep 8, 2017

image

Another user said in the past he had no issues downloading the client on older versions but couldn't download this one cleanly for some reason.

@mastergberry
Copy link
Contributor Author

mastergberry commented Sep 8, 2017

https://www.youtube.com/watch?v=Pb8Uenf-Dyw

A different user recorded this being an issue...I think they got it to work later, asking what they changed/how it was fixed or if they are still having issues.

@mastergberry
Copy link
Contributor Author

User from video claims to have moved to a new house and new ISP and this was how it got fixed for him...so many some ISP's are adding proxies automatically and causing issues which is probably beyond our scope of control?

@develar
Copy link
Member

develar commented Sep 8, 2017

causing issues which is probably beyond our scope of control?

Used NSIS plugin tries to use system/explorer proxy. We can try to download without proxy.

Yes — bypassing of ISP proxy is not "possible".

I will check issue when delta updates will be implemented.

@develar
Copy link
Member

develar commented Sep 10, 2017

We are going to promote web installer (since it is awesome) and this feature will be implemented in a short term.

@mastergberry
Copy link
Contributor Author

We only use awesome features at Badlion 🏆

@stale
Copy link

stale bot commented Jul 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Jul 2, 2019
@stale stale bot closed this as completed Jul 9, 2019
@develar develar removed the backlog label Jul 17, 2019
@develar
Copy link
Member

develar commented Jul 17, 2019

Addressed in 21.1.0, but only end user can verify that is fixed.

develar added a commit to develar/electron-builder that referenced this issue Jul 17, 2019
develar added a commit to develar/electron-builder that referenced this issue Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants