Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bintray publisher doesn't escape filename #2600

Closed
vassilevsky opened this issue Feb 18, 2018 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Bintray publisher doesn't escape filename #2600

vassilevsky opened this issue Feb 18, 2018 · 2 comments · May be fixed by qcif/data-curator#563

Comments

@vassilevsky
Copy link

Hello 🙃

First of all, THANK YOU for an amazing project! I was pleasantly surprised by how well it works with all the defaults!

NSIS builder uses ${productName} Setup ${version}.${ext} file name template by default. When it is uploaded to Bintray, the following error occurs:

TypeError: Request path contains unescaped characters

Full build log

I have changed artifactName to ${productName}-${version}.${ext} and it was uploaded without problems.

It seems that file name should be escaped before it is added to request path.

I used:

  • AppVeyor (your sample template)
  • node 8.9.4
  • electron-builder@20.0.5
@waseemballoul
Copy link

It’s a great project 👍👍

@develar develar changed the title Bintray upload of default Windows NSIS installer fails Bintray publisher doesn't escape filename Feb 19, 2018
develar added a commit to develar/electron-builder that referenced this issue Feb 19, 2018
@develar
Copy link
Member

develar commented Feb 19, 2018

Please try 20.0.6 (it is next release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants