Snapcraft review fails #3608
Comments
|
I analyzed the issue and found the problem: The problem is that the directories listet in the error message have se @develar I have seen, you have done some stuff with the snap template, do you have any idea where the gid flag of the I'm not to happy with the "repack" workaround 🤨 Details: |
|
Fixed in 20.44.0. |
develar
added a commit
to develar/electron-builder
that referenced
this issue
Jun 14, 2019
feat(snap): electron 5 support (part 2) Close electron-userland#3701, Close electron-userland#3677, Close electron-userland#3608, Close electron-userland#3326, Close electron-userland#2887
File appear to have Package outputSnapcraft Review result without repackaging
Snapcraft Review result as text |
|
@thomasnordquist Thanks for update. Could you please specify where exactly did you build — travis 16 or your server ubuntu 18? |
|
This build happened on Ubuntu Server 18.04. |
|
It is also the Test results, building on different machines:
|
|
You can use https://snapcraft.io/review-tools ( |
develar
added a commit
to develar/electron-builder
that referenced
this issue
Jun 20, 2019
develar
added a commit
to develar/electron-builder
that referenced
this issue
Jun 20, 2019
develar
added a commit
to develar/electron-builder
that referenced
this issue
Jun 20, 2019
|
Please try 20.44.3 |
|
I finished my tests, It runs everywhere except on my Ubuntu Server 18.04. Could the machine I'm building on still have outdated electron-builder related files floating around? Doing another test on a Ubuntu 18.04 VM (has probably never packaged before), if test is succeeding I might just live with a "corrupt build environment". I do most of my build on the ci anyways. Just to be certain I removed snapcraft and caches I could think of |
|
Interesting. Please build with env: `DEBUG=electron-builder` and attach
log. Please also provide output of command `umask`
…On Thu, Jun 20, 2019 at 9:29 PM Thomas Nordquist ***@***.***> wrote:
I finished my tests, It runs everywhere except on my Ubuntu Server 18.04.
20.44.3 did not resolve the issue.
Could the machine I'm building on still have outdated electron-builder
related files floating around?
Doing another test on a Ubuntu 18.04 VM (has probably never packaged
before), if test is succeeding I might just live with a "corrupt build
environment". I do most of my build on the ci anyways.
Just to be certain I removed snapcraft and caches I could think of
apt-get remove snapcraft
snap remove snapcraft
rm -rm ~/.caches/electron ~/.caches/electron-builder
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3608?email_source=notifications&email_token=AACVTXWD7NEOQMH6NSK27LLP3PLDFA5CNFSM4GQDURQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYGMHQI#issuecomment-504153025>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVTXWGPKOBNF3D7GGSUITP3PLDFANCNFSM4GQDURQQ>
.
|
|
A different Ubuntu 18.04 builds just fine ✔️ Ubuntu Server: I do another test, same machine but with a different user (to isolate the build context). If you like we can analyze this further, or keep it closed, your call. Review: umaskumask (on a working machine)0022 |
It means that electron-unpack is innocent, and app file copying is innocent. Simple Thanks for cooperation and detailed answers. |
|
No problem building with a different linux user... |
|
I am sure that it is some weird Linux issue. Regardless of how is bad your machine, it is not an excuse for electron-builder to silently produce corrupted snap. If I will not managed to fix it propery, I can always use |
|
I believe I got it... For some reasons the |
|
Sorry if I wasted your time... |
|
Fixed in 20.44.4. electron-builder goal to allow you just focus on your app and not on boring distribution process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building with https://hub.docker.com/r/electronuserland/builder
Publish with
The review when publishing snapcraft fails.
https://github.com/thomasnordquist/MQTT-Explorer
Steps: (packaging done with docker, publishing with systems snapcraft v3.0.1)
The text was updated successfully, but these errors were encountered: