-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can I disable differential download? #4682
Comments
I recently wanted to do the same. Checked the implementation and it seems there isn't currently a way to disable differential downloads. In my case I am still using the Nuts server for downloads and it doesn't support either blockmap files or HTTP ranges. Your best bet would be to fork electron-updater. |
@akorchev Thanks for the suggestion. I would leave the fork solution as a last resource, don't want to deal with the maintenance and extra tests for it. I'm currently considering deleting the blockmap after the publish and add a handler to the exception thrown. Any thoughts on that or warns are more than welcome. |
I'm also interested in disabling this default behavior. I think this should be relatively simple to add as a property. @develar wdyt? autoUpdater.differentialDownload = false By setting this to false, electron-updater should automatically fallback to a full download and not try to download blockmaps or throw exceptions. |
If you look at the electron-builder configuration documentation you can find this option so this option autoUpdater.differentialDownload = false is still needed to prevent unnecessary download attempts. |
|
If I don't add |
I think this is not correct. Per the documentation
It just defaults to true for web installer. It doesn't mean that it only works on it. In my experience if you set it false, it will full download the package. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hey! Just curious, what was the reason you wanted to disable differential updates? Are they are worse in some ways? |
@indutny-signal In my case it was because it was a government project with a strict update procedure so there were no downloads at all and it looked like this feature added considerably to the build process (whether that is true or not I don't know). So I wanted to disable them to see the difference, and because they weren't being used anyway. |
@indutny-signal In my case it was the fact that the differential downloader failed every time. The biggest problem is when it was checking if the differential could be applied. It froze my application's main process for a couple minutes which is unacceptable for end-users. |
@kylegundersen oh no, thanks for sharing! |
Why was this issue closed? |
add new option to skip differential download attempt and default to full download Closes electron-userland#4682
add new option to skip differential download attempt and default to full download Closes electron-userland#4682
electron-builder: 21.2.0
electron-updater: 4.2.0
Target: NSIS
I want to disable differential download on NSIS using electron-updater, so it always fallback to full download. Is there a way to do it?
The text was updated successfully, but these errors were encountered: