Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug-n-Play Support #4688

Closed
dbkr opened this issue Feb 20, 2020 · 1 comment
Closed

Plug-n-Play Support #4688

dbkr opened this issue Feb 20, 2020 · 1 comment
Labels

Comments

@dbkr
Copy link

dbkr commented Feb 20, 2020

  • Version: 22.3.2
  • Target: win, macos, linux debian

As far as I can see, electron-builder doesn't support plug-n-play (ie. yarn 2) module structure: I tried using yarn 2 and get an app that doesn't contain any of the dependencies (and indeed doesn't launch because it can't find its dependencies).

This seems surprising since there are PRs that explicitly mention PnP, eg. #4147 which makes electron-builder look for the .pnp.js file when determining if modules need to be installed, which would imply that electron-builder is expected to work in a pnp project.

@stale
Copy link

stale bot commented Apr 22, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 22, 2020
@stale stale bot closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant