fix(app-builder-lib): yarn install break on 'electron-builder install-app-deps' when used pnp #4147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use yarn with enabled plug’n’play option, it means that node_modules directory doesn't exist instead used .php.js file.
electron-builder/packages/app-builder-lib/src/util/yarn.ts
Lines 16 to 18 in ebbd9f7
File contains a path resolver and mapping to dependencies paths (include devDependencies). When electron-builder calls installDependencies then .php.js file will be overwritten (without devDependencies) that break process because builder needs in devDependencies on runtime.
electron-builder/packages/app-builder-lib/src/util/yarn.ts
Line 75 in ebbd9f7