Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 bit + 64 bit installer #536

Closed
ghost opened this issue Jun 23, 2016 · 10 comments
Closed

32 bit + 64 bit installer #536

ghost opened this issue Jun 23, 2016 · 10 comments

Comments

@ghost
Copy link

ghost commented Jun 23, 2016

OK this is quite needed for NSIS. I get no error at all after installing a 64-bit app on windows 32. (during install). But trying to open the app just nothing appears, no error either. Just nothing. So would be confusing to users. That's why a bundled installer probably is best.

@develar
Copy link
Member

develar commented Jun 23, 2016

Required refactoring is already done, I am working on this.

@ghost
Copy link
Author

ghost commented Jun 23, 2016

ok did something happen in one of the recent releases because my app just got 30MB bigger in size (the exe of the app, not installer)

@develar
Copy link
Member

develar commented Jun 23, 2016

@kunkinkan Please compare asar files (app.asar).

@ghost
Copy link
Author

ghost commented Jun 23, 2016

The app.asar is actually smaller in the newer version. But the "App Name.exe" (in Appdata/Local/Programs/App Name/App Name.exe") is 30MB bigger. Does this exe include the node modules or is that in the app.asar ? (i didn't extract it)

@develar
Copy link
Member

develar commented Jun 24, 2016

@kunkinkan we don't modify exe (it is from electron dist, as is) — we only set icon and sign it. Please try latest electron version — my app size is the same as before.

@ghost
Copy link
Author

ghost commented Jun 24, 2016

Now it's back to normal size, no idea what happened. Anyway this was off-topic, should I open another issue about 32+64 bit installer or can we keep this open ? (sorry!)

@develar
Copy link
Member

develar commented Jun 26, 2016

Fixed as part: If installer contains only x64 package — error will be thrown.

@develar
Copy link
Member

develar commented Jun 26, 2016

Size of installer: 59M. ia32 package 26M, x64 30MB. Solid? Well, no time. To investigate, will be not fixed for now.

@cyrus19901
Copy link

I am still facing the same issue. Where on building distribution for 64 bit I am getting 32 bit .Any solution to that ?

@Anil8753
Copy link

@cyrus19901, did you able to solve this issue. After building the package on 64-bit windows, I am getting a final executable and that is 32-bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants