-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32 bit + 64 bit installer #536
Comments
Required refactoring is already done, I am working on this. |
ok did something happen in one of the recent releases because my app just got 30MB bigger in size (the exe of the app, not installer) |
@kunkinkan Please compare asar files ( |
The app.asar is actually smaller in the newer version. But the "App Name.exe" (in Appdata/Local/Programs/App Name/App Name.exe") is 30MB bigger. Does this exe include the node modules or is that in the app.asar ? (i didn't extract it) |
@kunkinkan we don't modify exe (it is from electron dist, as is) — we only set icon and sign it. Please try latest electron version — my app size is the same as before. |
Now it's back to normal size, no idea what happened. Anyway this was off-topic, should I open another issue about 32+64 bit installer or can we keep this open ? (sorry!) |
Fixed as part: If installer contains only x64 package — error will be thrown. |
Size of installer: 59M. ia32 package 26M, x64 30MB. Solid? Well, no time. To investigate, will be not fixed for now. |
I am still facing the same issue. Where on building distribution for 64 bit I am getting 32 bit .Any solution to that ? |
@cyrus19901, did you able to solve this issue. After building the package on 64-bit windows, I am getting a final executable and that is 32-bit. |
OK this is quite needed for NSIS. I get no error at all after installing a 64-bit app on windows 32. (during install). But trying to open the app just nothing appears, no error either. Just nothing. So would be confusing to users. That's why a bundled installer probably is best.
The text was updated successfully, but these errors were encountered: