-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-version override property #565
Comments
If version in the package.json is
So, I don't understand "with an app-version like 1.0.50 and the build-version is set to just 50" Do you mean build number?
What it is the version in your package.json? |
Basically, I want to be able to set the app-version and build-version to different strings. At the moment it just sets them both to the same version in the package.json. I want Within electron-packager I can set these versions independently, but within electron-builder I can not do that. It would be nice to have these same options within electron-builder Edit: I realise that the version should probably have just been left so both |
It is valid and recommended way to set.
So, if you set Or do you use |
Yes, I need to use a 50+ CFBundleVersion as the build needs to be higher for the Mac app store. There doesn't seem to be any way to stop the Any ideas how this could be fixed for a future update? |
|
@elronalds 5.11.0 is available. Please see bundleVersion . |
Summary: This defaults to the `version` and is used to update the inline plists of the Frameworks that are bundled with the MacOS app bundle. Setting them to a fixed value means that they remain unchanged across rebuilds (bringing them in line with Linux and Windows equivalents). This is required to ship them as separate bundles for the launcher. Why 50? The reason this was introduced was to allow people to override this to values >= 50 as this is somehow a Mac App Store requirement: electron-userland/electron-builder#565 (comment) Reviewed By: priteshrnandgaonkar Differential Revision: D21179072 fbshipit-source-id: a6f10b7508526b4305b229bd160d6e570ddce822
I'd have an existing app in the app store with an app-version like 1.0.50 and the build-version is set to just 50. It doesn't seem like I can override the build-version that is passed into electron-packager.
The Mac app store will decline my app if I try to submit it as 1.0.50 as that isn't higher than the build version 50. I don't really want to change the app version from 1.0.50 to 51.0.51 either.
Any chance we could have a property added to do this that completely overrides the build version in the Mac app plist file?
If I add the
"build-version"
property to the"build"
section it seems to append that to the end of my version string. Should it be doing that or is there a way to override that?The text was updated successfully, but these errors were encountered: