[20.10.x] "icon directory [...]/build doesn't contain icons" when targetting linux/deb/x64

[AviVahl]

• Version: 20.10.5

• Electron Version: 12.0.0
• Electron Type (current, beta, nightly): current

• Target: linux/deb/x64

Getting a build failure of electron-builder trying to load icons:

⨯ icon directory /home/avi/projects/electron-app/build doesn't contain icons
github.com/develar/app-builder/pkg/icons.CollectIcons
        /Volumes/data/Documents/app-builder/pkg/icons/collect-icons.go:73
github.com/develar/app-builder/pkg/icons.doConvertIcon
        /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:191
github.com/develar/app-builder/pkg/icons.ConvertIcon
        /Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:66

My config is fairly simple:

{
  "appId": "com.test.electron-app",
  "productName": "electron-app",
  "directories": {
    "output": "./build"
  },
  "files": ["node_modules", "dist"],
  "asar": false,
  "linux": {
    "target": [
      {
        "target": "deb",
        "arch": ["x64"]
      }
    ]
  },
  "win": {
    "publisherName": "Test",
    "target": [
      {
        "target": "nsis",
        "arch": ["x64"]
      }
    ]
  },
  "mac": {
    "target": [
      {
        "target": "dmg",
        "arch": ["x64"]
      }
    ]
  }
}

v22.9.1 is the last working version when it doesn't fail because of the icons.
Needless to say, I don't have any icons that I'm trying to set.

[mmaietta]

Nice catch. Will fix this asap.

[aplonska]

I got the same error:

  ⨯ icon directory /Users/olunia/sandbox/notebook-private/assets/icons doesn't contain icons
github.com/develar/app-builder/pkg/icons.CollectIcons
	/Volumes/data/Documents/app-builder/pkg/icons/collect-icons.go:73
github.com/develar/app-builder/pkg/icons.doConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:191
github.com/develar/app-builder/pkg/icons.ConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:56
github.com/develar/app-builder/pkg/icons.ConfigureCommand.func1
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:33

I'm packaging the app on Mac. For Linux it is working OK. I don't have icon parameter specified and no icon files (the same as @AviVahl).

Versions:

• "electron": "^11.0.1",
• "electron-builder": "^22.10.5"

@mmaietta is there any fix to switch off this check?

[AviVahl]

Try using electron-builder@22.11.7 or above. The issue is no longer reproducing on our end.

[aplonska]

@AviVahl thank you for help.

I've updated the electron-builder to 22.12.0. Still get error:

[1] yarn build:renderer exited with code 0
  • electron-builder  version=22.12.0 os=20.6.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=release/builder-effective-config.yaml
  • packaging       platform=darwin arch=x64 electron=11.4.11 appOutDir=release/mac
  • asar usage is disabled — this is strongly not recommended  solution=enable asar and use asarUnpack to unpack files that must be externally available
  ⨯ icon directory /Users/olunia/sandbox/notebook-private/assets/icons doesn't contain icons
github.com/develar/app-builder/pkg/icons.CollectIcons
	/Volumes/data/Documents/app-builder/pkg/icons/collect-icons.go:73
github.com/develar/app-builder/pkg/icons.doConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:191
github.com/develar/app-builder/pkg/icons.ConvertIcon
	/Volumes/data/Documents/app-builder/pkg/icons/icon-converter.go:56

... the rest of error ...

any ideas? Maybe update the electron version?

[AviVahl]

We use the latest stable of both... I doubt the electron version affects the icon loading behavior of electron-builder. Perhaps maintainers can clarify though.

[aplonska]

@AviVahl looks like the problem was on my side. I had assets/icons folder with some images and when I changed the name of the directory everything worked smoothly.

Thank you for your help. Looks like this issue can be closed.