-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dmg-license is an optional dependency, so building fails caused by 'npm ci --no-audit --no-optional' #6489
Comments
It's not possible to move it to dependencies option because |
I have also encountered this problem. The dependency of dmg-license seems to be added after electron-buider@20.39.0. The dmg-license is not used in version 20.39.0, which can avoid this problem. For normal applications, it should be Doesn't need a license |
For anyone coming across this, i solved my problem with selecting macos 10.15
My build.yml for mac looks like this
|
Cannot find module 'dmg-license' when building Electron app electron-userland/electron-builder#6520 cf. electron-userland/electron-builder#6489 (comment) https://github.blog/changelog/2021-09-29-github-actions-jobs-running-on-macos-latest-are-now-running-on-macos-big-sur-11/
I had the same issue with npm install "dmg-license" --save-optional This adds following lines to package.json: "optionalDependencies": {
"dmg-license": "^1.0.11"
}, |
- Migrate from "Vue 2.X" to "Vue 3.X" - Migrate from "Vue Test Utils v1" to "Vue Test Utils v2" Changes in detail: - Change `inserted` to `mounted`. - Change `::v-deep` to `:deep`. - Change to Vue 3.0 `v-modal` syntax. - Remove old Vue 2.0 transition name, keep the ones for Vue 3.0. - Use new global mounting API `createApp`. - Change `destroy` to `unmount`. - Bootstrapping: - Move `provide`s for global dependencies to a bootsrapper from `App.vue`. - Remove `productionTip` setting (not in Vue 3). - Change `IVueBootstrapper` for simplicity and Vue 3 compatible API. - Add missing tests. - Remove `.text` access on `VNode` as it's now internal API of Vue. - Import `CSSProperties` from `vue` instead of `jsx` package. - Shims: - Remove unused `shims-tsx.d.ts`. - Remove `shims-vue.d.ts` that's missing in quickstart template. - Unit tests: - Remove old typing workaround for mounting components. - Rename `propsData` to `props`. - Remove unneeded `any` cast workarounds. - Move stubs and `provide`s under `global` object. Other changes: - Add `dmg-license` dependency explicitly due to failing electron builds on macOS (electron-userland/electron-builder#6520, electron-userland/electron-builder#6489). This was a side-effect of updating dependencies for this commit.
- Migrate from "Vue 2.X" to "Vue 3.X" - Migrate from "Vue Test Utils v1" to "Vue Test Utils v2" Changes in detail: - Change `inserted` to `mounted`. - Change `::v-deep` to `:deep`. - Change to Vue 3.0 `v-modal` syntax. - Remove old Vue 2.0 transition name, keep the ones for Vue 3.0. - Use new global mounting API `createApp`. - Change `destroy` to `unmount`. - Bootstrapping: - Move `provide`s for global dependencies to a bootsrapper from `App.vue`. - Remove `productionTip` setting (not in Vue 3). - Change `IVueBootstrapper` for simplicity and Vue 3 compatible API. - Add missing tests. - Remove `.text` access on `VNode` as it's now internal API of Vue. - Import `CSSProperties` from `vue` instead of `jsx` package. - Shims: - Remove unused `shims-tsx.d.ts`. - Remove `shims-vue.d.ts` that's missing in quickstart template. - Unit tests: - Remove old typing workaround for mounting components. - Rename `propsData` to `props`. - Remove unneeded `any` cast workarounds. - Move stubs and `provide`s under `global` object. Other changes: - Add `dmg-license` dependency explicitly due to failing electron builds on macOS (electron-userland/electron-builder#6520, electron-userland/electron-builder#6489). This was a side-effect of updating dependencies for this commit.
We are building our application by making use of Github Actions. The steps are:
The last command fails with
⨯ Cannot find module 'dmg-license'
After inspecting the package.json of electron-builder/packages/dmg-builder I found
dmg-license
to be declared optional.If electron-builder depends on dmg-license can you please move it to the dependencies section?
Thanks!
The text was updated successfully, but these errors were encountered: