Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS warnings as errors #763

Closed
worldjoe opened this issue Sep 20, 2016 · 1 comment · May be fixed by qcif/data-curator#563
Closed

NSIS warnings as errors #763

worldjoe opened this issue Sep 20, 2016 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@worldjoe
Copy link
Contributor

  • Version: 6.7.6
  • Target: nsis

I use nsis File's /nonfatal flag to allow my developer builds to ignore that large msi's included in our installer aren't in github. The signing server pulls those large msi files into the build directory before running electron builder. The nonfatal flag spits out a warning (by design) instead of an error when the file doesn't exist.

Unfortunately electron-builder treats all warnings as errors. The -WX option is passed to makensis
https://github.com/electron-userland/electron-builder/blob/master/src/targets/nsis.ts#L188

I suggest a flag that can be passed to nsis to optionally disable the -WX flag.

Pull request coming.

worldjoe pushed a commit to worldjoe/electron-builder that referenced this issue Sep 20, 2016
@worldjoe
Copy link
Contributor Author

#764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants