-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Must be error if file association is set, but perMachine not #772
Comments
Works for me. Nothing changed. Please provide sample project or set debug env
Do not specify app icon — it is default value in any case. |
Sadly i cant send you the project, but im willing to help in other ways. We have tested on several machines now and non of them works. How do you set the debug variable? |
Please try to not set icon at all. Since it is equal to app icon, no need to set it explicitly.
It is an environment variable. Set |
No icon? Could you please attach screenshot of file in the File Explorer? Or your app is not opened on file double click? |
Yes, app does not open on double click and icon is just a white standard "no specific icon" icon. |
Do you use |
No. |
Because Windows is *** Windows, per-user installed program cannot register file associations. Yes — it is not documented. Yes — we must throw error if file associations set, but |
perMachine
not
perMachine
not
But you just said that "per-user installed program cannot register file associations", doesn't that mean that you should set error if file associations set and perMachine is TRUE? For my case its set to false? |
|
Ahh, i thought perMachine true was that it should install for one user only, i will try change this then : ) |
Ok, now the association works : ) |
Did you remove unnecessary |
No, but i think its just some cache issue, cause when i try to open a file inside of the program, the icon shows. Thanx for the help! |
I can see that it throws an error now, if I have fileAssociations set to true and perMachine to false. Can we set it for macOS only, so it does not fail when perMachine is false, but we still want it on Mac? |
@jakubzitny Just move |
Thanks, it works. |
After updating to latest electron-builder, file association including icon stopped working. Worked perfectly before updating, i think last version was the last 6.x, but cant remember exactly.
Using NSIS
"fileAssociations": {
"ext": ".aepwx",
"name": "myName",
"icon": "build/icon.ico"
}
The text was updated successfully, but these errors were encountered: