feat(nsis): implement file associations per user #2861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you give me a few pointers where to write tests for that feature? |
nikku
force-pushed
the
file-assoc-per-user
branch
2 times, most recently
from
33322c8
to
88ed9e5
Compare
|
I've removed the assertion testing for |
By writing the relevant entries either to HKEY_LOCAL_MACHINE\Software\Classes or to HKEY_CURRENT_USER\Software\Classes we're able to support file associations on user installations, too. Closes electron-userland#2860
|
@clusterberries Hi, it seems per-user is possible :) |
|
Ouch, it really works. @nikku You are hero. |
existing test is enough, for now not possible to automate this check (checked manually that association works). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By writing the relevant entries either to
or to
we're able to support file associations on user installations, too.
Closes #2860.