Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: add electron-builder.env to default ignores in files #7777

Closed
dkaser opened this issue Sep 13, 2023 · 1 comment · Fixed by #7792
Closed

Configuration: add electron-builder.env to default ignores in files #7777

dkaser opened this issue Sep 13, 2023 · 1 comment · Fixed by #7792

Comments

@dkaser
Copy link
Contributor

dkaser commented Sep 13, 2023

  • Electron-Builder Version: 24.6.4

  • Node Version: 20.5.1

  • Electron Version: 26.1.0

  • Electron Type (current, beta, nightly): current

  • Target: all

Currently, if you use electon-builder with default settings and an electron-builder.env file, electron-builder.env is included in the packaged application. This can result in inadvertent secrets exposure. electron-builder.env should be added as a default ignore for the files option.

@mmaietta
Copy link
Collaborator

Great callout. I'm not sure if there's previous reasoning as to why the env file should be allowed to be included. Maybe it's so that electron apps can still use the file env data at runtime? That's my only hesitation in adding it to default ignore.

Would you mind opening a PR for this change? (Always trying to encourage community contributions 🙂 )

The logic exists here: https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/fileMatcher.ts#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants