Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude electron-builder.env from app #7792

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

dkaser
Copy link
Contributor

@dkaser dkaser commented Sep 22, 2023

Adds electron-builder.env to the default file ignore list.

Documentation currently suggests the use of this file for environment variable. However, if a developer uses electron-builder.env to store secrets (a common development practice), the default configuration will include these secrets in the packaged app. Adding the file to the default ignore list prevents this inadvertent secret disclosure.

Closes #7777

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 6a1b89a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 6a1b89a
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6511af0cfa5cfd000842ad4f
😎 Deploy Preview https://deploy-preview-7792--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 84906bc into electron-userland:master Sep 25, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration: add electron-builder.env to default ignores in files
2 participants