snapcraft is required in building snap (provider: github) after 24.9.2

[JellyBrick]

• Electron-Builder Version: 24.13.1, 24.12.0
• Latest Known Working Electron-Builder Version: 24.9.1

• Node Version: 20 (GitHub Actions)

• Electron Version: 28.2.3
• Electron Type (current, beta, nightly): current

• Target: Linux x64

The build failed with this error.

 ⨯ snapcraft is not installed, please: sudo snap install snapcraft --classic  

Detailed log: https://github.com/th-ch/youtube-music/actions/runs/7969007984/job/21754132043

We are using pnpm (8.15.3)

[mmaietta]

Hmmm, we never updated app-builder-bin between those versions and that's what pulls the electron-builder-binaries (such as appimage-12.0.1

I'm not seeing any immediately obvious changes in the diff either
v24.9.1...v24.12.0

Is this issue 100% reproducible for you? It's not appearing in our unit tests either

[JellyBrick]

• 24.12.0
  • https://github.com/th-ch/youtube-music/actions/runs/7968235719/job/21752174790
  • https://github.com/th-ch/youtube-music/actions/runs/7968236579/job/21752176733
  • https://github.com/th-ch/youtube-music/actions/runs/7968247870/job/21752928339
• 24.13.1
  • https://github.com/th-ch/youtube-music/actions/runs/7969007984/job/21754132043
• 24.9.1
  • https://github.com/th-ch/youtube-music/actions/runs/7969339455/job/21755000082

24.9.1 -> 24.12.0 commit

th-ch/youtube-music@6358a2d

24.13.1 -> 24.9.1 commit

th-ch/youtube-music@8bd05f5

Yes, this issue is 100% reproducible in this repository (https://github.com/th-ch/youtube-music)

[JellyBrick]

still reproducible these issues in 24.13.3

https://github.com/th-ch/youtube-music/actions/runs/8125045551/job/22207198684

[JellyBrick]

• 24.9.2: Successful
• 24.9.3: Failed

v24.9.2...v24.9.3

Additional Information

CI fails when snap + AppImage builds are enabled.

[cmdcolin]

what was the resolution to this? I don't currently want to setup snapcraft but want to publish snap files

[mmaietta]

How would you bundle a snap distributable but not set up snapcraft? That seems like mutually exclusive

[cmdcolin]

I am not really sure. I just had a setup that "worked" and was creating and releasing .snap files to github but then it stopped working after a electron-builder version upgrade similar to what @JellyBrick had experienced. my understanding is using snapcraft and such would release to the snap store? i just removed snap builds for now in our project...it's pretty low usage

[JellyBrick]

what was the resolution to this? I don't currently want to setup snapcraft but want to publish snap files

@mmaietta @cmdcolin

It can't; for versions after 24.9.4, you must install snapcraft before you can bundle snap.

th-ch/youtube-music@d09858c