-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 10 Icon Missing In Application Bar #810
Comments
Do you mean that icon is visible on Windows 7 or 8? Have you tried nsis target? |
@develar Yup windows 7 and 8 are perfect. will try the nsis target, maybe that will fix it. |
@develar Tried the target: "nsis", didnt work. |
In my case, I do not see the blank icon on both Win 7/10. The unpacked executable (before being packaged in the installer) does work just fine though. However, if I try the executable in my AppData\Local\Application\app-version folder, then I have no icon, even though I can see one displayed in I'm using the Squirrel target (electron-builder ^6.7.3 as well as ^7.12.2). After further investigation, it appears the problem might be path related. If I move the folder somewhere else than AppData\Local\Application\app-version and run it, the icon is displayed without problem. |
Sorry for delay, I am currently busy on other issues. It works for me (it is Squirrel.Windows app on Windows 10 latest release) — Further investigation is not possible since I cannot reproduce :) If it is important for you — well, you can help us to investigate/fix. Or just use nsis target and set |
BTW, my app is signed. |
Could you please specify your application product names (spase/special symbols/unicode)? |
After further inspection, I'd say the issue is related to the filename. If I leave everything the same, except that I rename the executable, then the icon appears in the taskbar. I thinking it might have something to do with the registry at this point since I don't see anything else that would keep this kind of information about an application/executable. I did try to compare the operations executed by using ProcMon, but I haven't found anything of interest searching for "icon". |
@tomzx That's why I ask you "please specify your application product names (spase/special symbols/unicode)?" :) |
@develar By renaming, I meant changing |
@develar Maybe this might help -- its my build setup in the package.json. "build": {
"appId": "com.electron.talkfusion.platform",
"productName": "Talk Fusion",
"win": {
"loadingGif": "build/loading-icon.gif",
"certificateFile": "build/codesigning-certificate.p12"
},
"mac": {
"category": "public.app-category.productivity"
},
"dmg": {
"title": "Talk Fusion Installer",
"background": "build/background.png",
"contents": [
{
"x": 448,
"y": 344,
"type": "link",
"path": "/Applications"
},
{
"x": 192,
"y": 344,
"type": "file",
"path": "Talk Fusion.app"
}
],
"window": {
"side": {
"width": 640,
"height": 480
}
}
}
} |
@ryanpager Have you attempted to change the executable name once it is installed to see if you get the same behavior I have, that is, once renamed, the icon is shown in the taskbar? I simply want to confirm we're experiencing a similar issue and not two different issues (which would deserve to be tracked separately). |
@tomzx Hmmm I havent tried that -- will try that tomorrow morning when im back at work. |
Also, please try to restart Windows. |
@develar Tested by rebooting on Windows 10. Issue is still present. |
It is ok. (it is minimum allowed size). |
Any other suggestions on this @develar? Its not a game breaker, but its definitely annoying our users. |
Please try upcoming 10.2.0 |
So 10.2.0 fixed the icons on NSIS installers -- but not the squirrel target. Unfortunately, I have to use the squirrel builder because of auto updates (for reference, I use https://github.com/ArekSredzki/electron-release-server). Anyhow, my understanding is that NSIS will not recognize the auto updates -- and even if it did it would not general the nupkg files that I need. Is that understanding correct, or am I a little bit sideways on my thinking? Is there something else I could try here to generate the nupkg files for windows, or fix this? Either way -- thank you so much for spending the time to help with this (and anyone else). This is not a critical issue for me, but it is annoying to see the white file icon instead of a nice one :) |
@ryanpager Probably upgrade to Squirrel.Windows 1.5.0 will help you. I am going to upgrade this week especially to address your issue. |
NSIS supports auto-update, please see https://github.com/electron-userland/electron-builder/wiki/Auto-Update Do you need nupkg only for https://github.com/ArekSredzki/electron-release-server? |
So everything works great -- application runs, no errors nothing. However, on windows 10 only the icon does not show up in the application bar -- only a blank file icon. On all other platforms, the icon works perfectly.
The icon was generated as the proper file type (ico & icns), and is the correct size. Im not sure what else I should be checking, but the problem only happens on windows 10.
Any ideas on this one?
The text was updated successfully, but these errors were encountered: