Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild with --no-bin-links option #869

Closed
MTRNord opened this issue Nov 2, 2016 · 5 comments · May be fixed by qcif/data-curator#563
Closed

Rebuild with --no-bin-links option #869

MTRNord opened this issue Nov 2, 2016 · 5 comments · May be fixed by qcif/data-curator#563

Comments

@MTRNord
Copy link

MTRNord commented Nov 2, 2016

  • Version: 7.18.0
  • Target: Linux

I want to build in Jenkins (which runs inside docker on windows) therefor I need the --no-bin-links option in node. But when it does the npm rebuild part it fails because it is missing the --no-bin-links. Is there a way to add this option at build to fix this issue?

@develar develar closed this as completed in cf24b01 Nov 3, 2016
@MTRNord
Copy link
Author

MTRNord commented Nov 3, 2016

Thanks :)

@lgeiger
Copy link
Contributor

lgeiger commented Nov 3, 2016

@develar Thanks for maintaining this awesome package.

After upgrading to 7.19.1 we run into npm/npm#9953 on windows because the --no-bin-links flag doesn't work correctly.
Could we make it optional?

Here is the full error: https://ci.appveyor.com/project/nteract/nteract/build/1.0.652/job/0ij1f4vrs2aaeg8o#L77

Keep up the great work 👍

@develar
Copy link
Member

develar commented Nov 4, 2016

npm must die, yarn FTW :( npm/npm#10776 ok, will be investigated.

@develar
Copy link
Member

develar commented Nov 4, 2016

Env NPM_NO_BIN_LINKS is added. Set it to true — NPM_NO_BIN_LINKS=true to force usage of --no-bin-links I hope yarn will replace npm soon.

@lgeiger
Copy link
Contributor

lgeiger commented Nov 4, 2016

@develar Thank you a lot for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants