Cannot download differentially

[cubimon]

I do get the following error message when trying to update my electron application:

Cannot download differentially, fallback to full download: Error: Content-Type "multipart/byteranges" is expected, but got "application/octet-stream" 

After some investigation I found out that Apache HTTPD was the cause and for some reason it doesn't like the way the Range header is created in the multipleRangeDownloader.js. So the Range Header looks like this:

Range: bytes=1-2, 3-4

and Apache HTTPD doesn't like the whitespace after the comma for some reason, so for compatibility reason we should remove the whitespace after the comma, so it looks like this:

Range: bytes=1-2,3-4

Nginx doesn't care about whitespace, it works in both cases.

I couldn't find anything specific to whitespace in the RFC, but examples didn't have whitespace for multiple ranges as well: https://datatracker.ietf.org/doc/html/rfc7233.

[mmaietta]

What version of electron-updater are you on? I thought @beyondkmp had put in a fix for handling differential ranges with and without spaces.

[cubimon]

electron-builder 4.6.5, where is the fix located? As workaround I did set useMultipleRangeRequest to false.

[cubimon]

Imo we should just changet this line from

ranges += `${task.start}-${task.end - 1}, `

to

ranges += `${task.start}-${task.end - 1},`

I could also create a PR for this. This should be compatible with existing servers like nginx and it is compatible with apache http after the space removal, also it is a few bytes less.

[mmaietta]

@beyondkmp can you take a look at this when you have a chance please?

[beyondkmp]

This issue has not been fixed yet; I fixed a different problem(#9064).