Adding ‘sign’ dmg option to scheme.json to fix build errors #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
reviewed
Jun 11, 2019
packages/app-builder-lib/scheme.json
Outdated
| @@ -802,6 +802,11 @@ | |||
| "window": { | |||
| "$ref": "#/definitions/DmgWindow", | |||
| "description": "The DMG windows position and size." | |||
| }, | |||
| "sign": { | |||
| "default": true, | |||
There was a problem hiding this comment.
According to ef0028d#diff-95f823016d05ece1f904f6c59a352ebaR190 the default is false. That file might need to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a build issue with the 'sign' dmg configuration mentioned in #3870