Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contrib): Add mention of missing mkdocs dep #4284

Merged

Conversation

jeffreypriebe
Copy link
Contributor

Trying to build docs, missing a python dep (added to contrib readme) and additional info for getting the docs built.

Should we just move the mkdocs.yml from master branch to docs?

and additional mkdocs build line
@develar
Copy link
Member

develar commented Oct 22, 2019

Should we just move the mkdocs.yml from master branch to docs?

No, it should be in the root. Well, there is a way to move to docs, but for simplicity it is in the root.

Thanks for fix.

@develar develar merged commit 4e73026 into electron-userland:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants