Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Squirrel Windows Description Error #4292

Merged

Conversation

1nfility
Copy link
Contributor

@1nfility 1nfility commented Oct 5, 2019

A Description in package.json is required if you want to successfully build a windows installer with squirrel.
I've added simple checks for that to alert the developer the error, instead of a 30 line mono error.

@develar develar merged commit 555fad2 into electron-userland:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants