Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing support for AppX fileAssociations #4302

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Added missing support for AppX fileAssociations #4302

merged 1 commit into from
Oct 22, 2019

Conversation

danielweck
Copy link
Contributor

@danielweck danielweck commented Oct 9, 2019

I tested this change using the following package.json ElectronBuilder build config:

    "fileAssociations": [
      {
        "ext": "ext1",
        "role": "Viewer",
        "mimeType": "application/ext1+zip"
      },
      {
        "ext": "ext2",
        "role": "Viewer",
        "mimeType": "application/ext2+zip"
      }
    ],

I am running a Windows 10 Pro Virtual Machine (VirtualBox), in "developer mode" so I can install my test AppX which is code-signed (via electron-builder's own certificateFile config) using a self-signed PFX certificate (generated using electron-builder create-self-signed-cert -p NAME) which I added in my "Trusted Root Certification Authorities" (using mmc.exe and a "Certificates" snap-in).

Once my test AppX is installed (simply by double-clicking on it from the Windows file explorer), I am able to double-click or "open with" from the file explorer the newly-registered ext1 and ext2 file extensions.

Once I uninstall the AppX, the file extensions are immediately unregistered, as expected.

@danielweck
Copy link
Contributor Author

Update: I added test/integration details in the PR description.

@develar develar merged commit b16a890 into electron-userland:master Oct 22, 2019
@develar
Copy link
Member

develar commented Oct 22, 2019

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants