Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-builder-lib): support to set executableArgs in linux config #4364

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

embbnux
Copy link
Contributor

@embbnux embbnux commented Oct 29, 2019

Would like to set executableArgs with executableName in builder config. So it will generate desktop.Exec with args.

For example:

linux:
  target:
    - deb
  category: Telephony
  executableName: my-app-name
  executableArgs:
    - --no-sandbox

And will generate desktop file:

[Desktop Entry]
Name=My Name
Exec="/opt/My Name/my-app-name" --no-sandbox %U
Terminal=false

Can be used to fix #3872 electron/electron#17972

@p3x-robot
Copy link

ciao, does it work with snap as well?

@p3x-robot
Copy link

sorry, i mean with app image, does it work with app image as well? i know snap is fixed already....

@p3x-robot
Copy link

besides, where do i put it if i use the package.json instead of yml?

@embbnux
Copy link
Contributor Author

embbnux commented Oct 30, 2019

@p3x-robot it doesn't work with AppImage. it doesn't generate desktop file for AppImage.
you can use same structure in package.json. It should be build.linux.executableArgs.

@ghost
Copy link

ghost commented Feb 2, 2020

besides, where do i put it if i use the package.json instead of yml?

"build": { "linux": { "executableArgs": [ "--no-sandbox" ] } }

@embbnux
Copy link
Contributor Author

embbnux commented Feb 3, 2020

besides, where do i put it if i use the package.json instead of yml?

"build": { "linux": { "executableArgs": [ "--no-sandbox" ] } }

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging Electron v5 with sandbox (linux)
3 participants