Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loginhelper entitlement option #5023

Merged

Conversation

jack-arms
Copy link
Contributor

@jack-arms jack-arms commented Jun 1, 2020

Addresses #3302 and #2035. See this PR for the main issue: electron-osx-sign right now has options only for entitlements used to sign every .app in the bundle. This is an issue for Mac App Store builds that want to use a login helper, because .app files aside from the login helper need to be signed with entitlements that look like:

<dict>
    <key>com.apple.security.app-sandbox</key>
    <true/>
    <key>com.apple.security.inherit</key>
    <true/>
</dict>

while the login helper must be signed with entitlements that look like:

<dict>
    <key>com.apple.security.app-sandbox</key>
    <true/>
</dict>

Changes to sign.js are lifted from that PR, and the rest of the changes are exposing that option from electron-builder and piping into electron-osx-sign.

jack-arms added 2 commits May 27, 2020 17:42
Port of changes from electron/osx-sign#210, plus changes to macPackager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants