Add loginhelper entitlement option #5023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3302 and #2035. See this PR for the main issue:
electron-osx-sign
right now has options only for entitlements used to sign every.app
in the bundle. This is an issue for Mac App Store builds that want to use a login helper, because.app
files aside from the login helper need to be signed with entitlements that look like:while the login helper must be signed with entitlements that look like:
Changes to
sign.js
are lifted from that PR, and the rest of the changes are exposing that option fromelectron-builder
and piping intoelectron-osx-sign
.