fix(nsis): keep injected logger state #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the CI failures are relevant to my changes, please advice on how to handle them. |
mmaietta
reviewed
Feb 17, 2021
| if (debug != null) { | ||
| debug(`download range: ${range}`) | ||
| if (this.logger.debug) { | ||
| this.logger.debug(`download range: ${range}`) |
There was a problem hiding this comment.
Can logger be null?
Alternative approach since we're in typescript, we can use optionals to avoid the extra if check.
this.logger?.debug?.(`download range: ${range}`)
Also, if you merge in the latest master, that should resolve the CI build errors.
This change avoids loosing state in the logger in case users inject a logger class instead of an object with functions.
mmaietta
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids loosing state in the logger in case users inject a logger class instead of an object with functions.