Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix husky not create hooks and improve lint when commit #5716

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix: fix husky not create hooks and improve lint when commit #5716

merged 1 commit into from
Mar 30, 2021

Conversation

codeudan
Copy link
Contributor

  1. ensure husky hooks install. husky5 changed behavior see:git commit hooks never get created when husky v5 is installed typicode/husky#866
  2. use "packages/**/*.ts": "eslint", this only lint staged file instead of run "pnpm lint", will lint more faster when commit

develar
develar reviewed Mar 18, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@codeudan codeudan marked this pull request as draft March 19, 2021 10:34
@codeudan codeudan marked this pull request as ready for review March 19, 2021 11:31
@codeudan
Copy link
Contributor Author

codeudan commented Mar 19, 2021 •
edited
Loading

@develar The huksy version is 5 now😀 , and ready for merge

@codeudan
Copy link
Contributor Author

@mmaietta Would you like to help review it?😀

mmaietta
mmaietta approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@mmaietta mmaietta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested your branch out locally. LGTM 👍

@mmaietta mmaietta merged commit 18e0c24 into electron-userland:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@develar develar develar left review comments

@mmaietta mmaietta mmaietta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeudan @develar @mmaietta