Fixing downloadPromise not resolving on Mac. #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We are using
autoInstallOnAppQuit=false(non mandatory updates). After the update, it stopped working for us on Mac. It's because we usedownloadPromiseto wait for the package to be downloaded. The promise never resolves on Mac. The promise never resolves because it depends onautoInstallOnAppQuitbeingtrueand the package being handed to Squirell.I am not sure whether this is the correct solution to this problem or whether it's just a misunderstanding of the API contract, but I am sure you folks can advise.
Additionally, I am not sure whether we want the HTTP server should be running for
autoInstallOnAppQuit=falseall the time. Perhaps the whole server should only be started whenautoInstallOnAppQuitistrueand onquitAndInstallcall whenautoInstallOnAppQuitisfalse. I am happy to take the code to that course if deemed suitable.Thank you for looking into this.