fix: quit on decompression errors in NSIS #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike 7zip, zip decompression pushes a return value on stack. If it not `success` installer should fail and display the error to the user instead of assuming that installation was successful. One of the causes of decompression errors might be a lingering child process that still uses dlls and node.js bindings so that they cannot be overwritten. In such case, prior to this patch nsis installer would update some of the non-locked files and start the app as if it had been fully updated.
|
Here's how the error message looks like:
|
|
Yay. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike 7zip, zip decompression pushes a return value on stack. If it not
successinstaller should fail and display the error to the userinstead of assuming that installation was successful.
One of the causes of decompression errors might be a lingering child
process that still uses dlls and node.js bindings so that they cannot be
overwritten. In such case, prior to this patch nsis installer would
update some of the non-locked files and start the app as if it had been
fully updated.