fix(nsis): should close app when Silent
and ONE_CLICK
#6100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if uninstall When
Silent is true
andONE_CLICK is defined
, the uninstaller will try to unisntall the app without closing it, which cases problems if uninstall it sliently when the app is running, the uninstaller can't remove all files, so left a broken app dir.How to reproduce:
create an app, set
"oneClick": true
in config, make aNSIS
installer, install it and tryUninstall {appName}.exe /S
to silently uninstall it when the app is running.Actual behavior: see above description.
Expected behavior: close the app then do the uninstall.