-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding snapStore to AllPublishOptions for generating Configuration schema #6193
fix: Adding snapStore to AllPublishOptions for generating Configuration schema #6193
Conversation
…erated via `pnpm schema`
🦋 Changeset detectedLatest commit: b723378 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -5287,7 +5292,8 @@ | |||
} | |||
}, | |||
"required": [ | |||
"provider" | |||
"provider", | |||
"repo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmaietta This should be channels
instead of repo
according to documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is actually autogenerated via pnpm run schema
The main location we need to change is making the repo optional and regenerating the schema
electron-builder/packages/builder-util-runtime/src/publishOptions.ts
Lines 231 to 247 in 2326bf1
export interface SnapStoreOptions extends PublishConfiguration { | |
/** | |
* The provider. Must be `snapStore`. | |
*/ | |
readonly provider: "snapStore" | |
/** | |
* snapcraft repo name | |
*/ | |
readonly repo: string | |
/** | |
* The list of channels the snap would be released. | |
* @default ["edge"] | |
*/ | |
readonly channels?: string | Array<string> | null | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
snapStore
toAllPublishOptions
for generatingConfiguration
schemafixes: #6190