fix: Add support for multiple extensions to Keygen publisher #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ezekg
changed the title
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
2 times, most recently
from
3e4e839 to
d4611b3
Compare
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
from
d4611b3 to
60fec8d
Compare
mmaietta
reviewed
Sep 6, 2021
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
4 times, most recently
from
24e1c9e to
f4de3d5
Compare
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
from
f4de3d5 to
cd44c24
Compare
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
from
88ccc8e to
9da54bc
Compare
ezekg
force-pushed
the
fix/keygen-publisher-version-taken-error
branch
from
9da54bc to
ba14a67
Compare
ezekg
commented
Sep 7, 2021
| import * as _sanitizeFileName from "sanitize-filename" | ||
| import * as path from "path" | ||
|
|
||
| export function sanitizeFileName(s: string): string { |
There was a problem hiding this comment.
Worth noting that renaming this file may be a breaking change if anybody is relying on util/sanitizeFileName. I assume it's meant to be internal, but ya know.
mmaietta
approved these changes
Sep 8, 2021
|
Many thanks, @ezekg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching multiple file extensions is tricky, but with a set heuristic, we can do it. I couldn't get the test env running (probably because I'm missing required env vars), but here's a repl I used to test.
Closes #6229.