Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dmg-builder): the "import" unbound issue #6672

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Feb 24, 2022

Fix #6606

python3 can't run our modified script since it can't find reload properly:

截圖 2022-02-24 下午1 49 52

As executePython("python3") failed, it fellback to executePython("python") and fail:

截圖 2022-02-24 下午3 28 38

NestedError: Cannot cleanup: 

Error #1 --------------------------------------------------------------------------------
Error: Exit code: ENOENT. spawn /usr/bin/python ENOENT
    at /Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/util.ts:133:18
    at exithandler (node:child_process:406:5)
    at ChildProcess.errorhandler (node:child_process:418:5)
    at ChildProcess.emit (node:events:520:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

Error #2 --------------------------------------------------------------------------------
Error: Exit code: ENOENT. spawn /usr/bin/python ENOENT
    at /Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/util.ts:133:18
    at exithandler (node:child_process:406:5)
    at ChildProcess.errorhandler (node:child_process:418:5)
    at ChildProcess.emit (node:events:520:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:289:12)
    at onErrorNT (node:internal/child_process:478:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
    at throwError (/Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/asyncTaskManager.ts:88:11)
    at checkErrors (/Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/asyncTaskManager.ts:53:9)
    at AsyncTaskManager.awaitTasks (/Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/asyncTaskManager.ts:58:5)
    at Packager.doBuild (/Users/pan93412/Projects/YesPlayMusic/node_modules/app-builder-lib/src/packager.ts:453:23)
    at Object.executeFinally (/Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/pan93412/Projects/YesPlayMusic/node_modules/app-builder-lib/src/packager.ts:376:31)
    at Packager.build (/Users/pan93412/Projects/YesPlayMusic/node_modules/app-builder-lib/src/packager.ts:337:12)
    at Object.executeFinally (/Users/pan93412/Projects/YesPlayMusic/node_modules/builder-util/src/promise.ts:12:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

🦋 Changeset detected

Latest commit: e5e8a72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
dmg-builder Patch
electron-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: e5e8a72

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62171ba58d37cd0007a4c09e

😎 Browse the preview: https://deploy-preview-6672--car-park-attendant-cleat-11576.netlify.app

@pan93412
Copy link
Contributor Author

r? @mmaietta

@pan93412 pan93412 marked this pull request as ready for review February 24, 2022 05:46
pan93412 added a commit to qier222/YesPlayMusic that referenced this pull request Feb 24, 2022
"electron-builder" is a monorepo; thus, it is not possible to
install from Git directly. Better to apply patch in
electron-userland/electron-builder#6672 manually.

This reverts commit 1542a66.
@mmaietta mmaietta merged commit 3a4b64a into electron-userland:master Feb 25, 2022
@github-actions github-actions bot mentioned this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS 12.3 Beta has removed the Python 2 support: spawn /usr/bin/python ENOENT
2 participants