Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-builder-lib): Overriding OutgoingHttpHeaders schema props #6775

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

mmaietta
Copy link
Collaborator

fix: Overriding additionalProperties to allow electron-builder's schema validator to read requestHeaders. It seems that the schema generator does not read NodeJS.Dict<number | string | string[]> properly, which then doesn't allow any entries for publish.requestHeaders to be provided.
Fixes: #6635

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: b3e0252

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit b3e0252
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62538037b11d08000941dc0e
😎 Deploy Preview https://deploy-preview-6775--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit e9a87a7 into master Apr 11, 2022
This was referenced Apr 11, 2022
@mmaietta mmaietta deleted the fix/OutgoingHttpHeaderProps branch February 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generic publisher config does not accept any requestHeaders
1 participant