fix(nsis): cleanup temporary 7z folder #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e477007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
indutny-signal
force-pushed
the
fix/7z-extract
branch
2 times, most recently
from
e1c1eb6
to
1c81d64
Compare
indutny-signal
force-pushed
the
fix/7z-extract
branch
from
1c81d64
to
30355d2
Compare
|
Sorry for ready->draft->ready transition. I've realized that I had an issue which I uncovered in testing (ABORT wasn't handled properly). Now the PR is ready for a review. |
indutny-signal
commented
Apr 14, 2022
packages/app-builder-lib/templates/nsis/include/extractAppPackage.nsh
Outdated
Show resolved
Hide resolved
Before attempting to extract files with non-discriminating `Nsis7z::Extract` that ignores the errors remove the temporary folder so that we don't require twice as much disk space for this last resort measure. Additionally, replace `Quit` with a `Goto DoneExtract7za` so that the last resort measure actually works.
indutny-signal
force-pushed
the
fix/7z-extract
branch
from
30355d2
to
e477007
Compare
Merged
|
Thanks for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before attempting to extract files with non-discriminating
Nsis7z::Extractthat ignores the errors remove the temporary folder sothat we don't require twice as much disk space for this last resort
measure.
Additionally, replace
Quitwith aGoto DoneExtract7zaso that thelast resort measure actually works.
Testing