fix: Update snapcraft.yaml to use gnome-3-38-2004 #6976
Conversation
The core18 and plug gnome-3-28-1804 lose standard (free/community) support in less than a year in accordance with the Ubuntu LTS timeline as these both correspond with Ubuntu 18.04 LTS, which loses standard support in April 2023 and moves to paid-only support. To continue to have secure builds for Electron apps, new snap builds should move to core20 and use plug gnome-3-38-2004. As an added bonus, this will also allow Ubuntu and official Ubuntu flavors to seed Electron snaps built with core20 and gnome-3-38-2004 because gnome-3-38-2004 provides the proper facility for this process.
🦋 Changeset detectedLatest commit: 7da6b86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
eeickmeyer
changed the title
|
electron-builder also do other weird things for snap; for example it opens a multipass on arm64 snap builds |
|
@ItzSwirlz Perhaps, but that's unrelated to this pull request. |
|
I actually now realize that this might not alone do the job. There are several 18.04-based dependencies that are being distributed as well that would need to be updated (as I tried a snap build with just updating the yaml file and the snap wouldn't run). Of course, I could be wrong there as well, but the long and short of it is that 18.04 dependencies should be moved to 20.04 ASAP. |
|
What are the 18.04-based dependencies? |
That would be pretty much everything listed under app: stage:. |
Missed section I assumed was a comment but was actually an integral part of this.
|
Oh jeez, I have no idea how one would transition it to 20.04, I'm not familiar with snaps or linux tbh. Happy to review a PR though 🙂 |
|
FYI, I am patching this for my electron build, simply changing |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Changing the base alone works, but I also need to update the gnome extension to fix bugs e.g. this one: https://forum.snapcraft.io/t/snapped-app-not-loading-fonts-on-fedora-and-arch/12484/116 When I update to app-builder-lib/templates/snap/snapcraft.yaml -base: core18
+base: core20
...
plugs:
- gnome-3-28-1804:
+ gnome-3-38-2004:
interface: content
target: $SNAP/gnome-platform
- default-provider: gnome-3-28-1804
+ default-provider: gnome-3-38-2004app-builder-lib/out/targets/snap.js const appDescriptor = {
+ extensions: ["gnome-3-38"],
command: "command.sh",
plugs: plugNames,
adapter: "none",
};The snap will not run, giving errors like: |
The core18 and plug gnome-3-28-1804 lose standard (free/community) support in less than a year in accordance with the Ubuntu LTS timeline as these both correspond with Ubuntu 18.04 LTS, which loses standard support in April 2023 and moves to paid-only support. To continue to have secure builds for Electron apps, new snap builds should move to core20 and use plug gnome-3-38-2004.
As an added bonus, this will also allow Ubuntu and official Ubuntu flavors to seed Electron snaps built with core20 and gnome-3-38-2004 because gnome-3-38-2004 provides the proper facility for this process.