fix: Ensure parent directories of symlinks are created #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6e7818f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gbodeen
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior: If a directory includes only symlinks, the directory is not created and so symlink creation fails. (Version: 23.6.0)
Fix: Create the parent directory or directories if needed using the fs-extra method "ensureSymlink". The dependency "fs-extra" is already present in this package.
Situation I was encountering: Our application has a directory in which there are currently only symlinks. The directory and contents are not created and the result is a failedTask=build error with message "ENOENT: no such file or directory, symlink 'path-to-target' -> 'path-to-symlink'". (I've redacted the paths.) I observed that if I added even one non-symlink file into the directory, then the directory and all its contents would be created successfully.