-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vendor information in releaseInfo #7373
feat: vendor information in releaseInfo #7373
Conversation
🦋 Changeset detectedLatest commit: 20cee51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/app-builder-lib/src/options/PlatformSpecificBuildOptions.ts
Outdated
Show resolved
Hide resolved
I actually have a bunch of TS errors when I run
|
That's weird, it just worked perfectly fine for me with |
I'd appreciate if you could do it. I'll try to figure it out on my end. |
We've been running a version of this patch internally for awhile and decided that it is time to submit it as a Pull Request.
The idea of this change is to allow to pass a custom
vendor
object down to the.yml
file. This object might have some custom properties on it likerequireManualUpdate
orminOSVersion
that the vendor's updater could be checking when deciding whether to update to this release or not.I understand that this will be ignored by the auto-updater bundled in electron-builder, but at least in our case we are running our own updater and we really find this additional information handy.