Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add signExts configuration option to not sign .node files by default #7685

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

mmaietta
Copy link
Collaborator

fix: allow explicit signExts configuration option for what additional files to sign. Do not sign .node files by default
Fixes: #7652

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: ad3b2e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for car-park-attendant-cleat-11576 failed.

Name Link
🔨 Latest commit ad3b2e2
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/64bec9a8948be4000886540d

@mmaietta mmaietta merged commit 78448af into master Jul 24, 2023
8 of 12 checks passed
@mmaietta mmaietta deleted the fix/signExts-default-exclude-node branch July 24, 2023 19:58
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code-Signing Windows on Mac, osslsigncode produces 'Unrecognized file type' error when signing .node modules
2 participants